Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverted colors mode for light backgrounds #28

Closed
piegamesde opened this issue Apr 21, 2020 · 4 comments
Closed

Add inverted colors mode for light backgrounds #28

piegamesde opened this issue Apr 21, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@piegamesde
Copy link

Is your feature request related to a problem? Please describe.

Currently the main text color is yellow. Which doesn't read well on a white terminal background.

Describe the solution you'd like

A CLI flag to switch to a dark color theme for better readability.

Describe alternatives you've considered

  • I don't know if it's a good idea, but simply inverting all colors might be enough
  • Full blown (custom) theme support
  • An environment variable or a configuration file are viable alternatives to CLI flags

Additional context

image

@extrawurst
Copy link
Owner

Hm that is a more complicated issue. But it is definitely important to find a solution for that since everyone uses different colorsets - so it is essential that the solution scales

@extrawurst extrawurst added the enhancement New feature or request label Apr 22, 2020
@extrawurst
Copy link
Owner

extrawurst commented May 14, 2020

Similar but less challenging than #57:

  1. refactor all Style objects that are generated on the fly all over the place to be statics first, because that allows us to figure out what are the common ones and derive the theme of gitui
  2. introduce a new struct Theme that holds values for all these values
  3. initialise this default Theme to look like it is right now
  4. use crossterm feature serde + ron-crate allowing us to save/load it in a decent format (*.ron)
  5. load the theme on startup if the file exists / dump the theme to file to make sure changes are reflected (additions)

@extrawurst extrawurst added the good first issue Good for newcomers label May 14, 2020
@MCord
Copy link
Contributor

MCord commented May 16, 2020

I am going to try to refactor the code and let you know how it goes.

@extrawurst
Copy link
Owner

see #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants