Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more navigation keys #43

Closed
data-man opened this issue May 7, 2020 · 8 comments
Closed

Use more navigation keys #43

data-man opened this issue May 7, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@data-man
Copy link

data-man commented May 7, 2020

Is your feature request related to a problem?
Use Home, End, PgUp and PgDn keys in diff and log panes.

Describe the solution you'd like
Scroll to top, bottom and by screen's height.

Describe alternatives you've considered
E.g. like tig.

@extrawurst extrawurst added the enhancement New feature or request label May 7, 2020
@extrawurst
Copy link
Owner

Hi @data-man thanks for your interest in the project! Thats indeed a great idea. Haven't thought of it since I am on a small laptop keyboard ;D

extrawurst pushed a commit that referenced this issue May 9, 2020
@bobismijnnaam
Copy link

bobismijnnaam commented May 10, 2020

This issue seems relevant to my request, so I will post it here instead of making a new issue if that is okay.

Any plans to support h, j, k, l for navigation? Some sites (i.e. duckduckgo) also support this natively, and as a vim user support would be nice. (I do not think any other vim bindings should be added, as that's way too opinionated. But basic hjkl support would be nice).

In any case, thanks for making gitui. Been using it for a bit and it works nice and fast!

@extrawurst
Copy link
Owner

Any plans to support h, j, k, l for navigation? Some sites (i.e. duckduckgo) also support this natively, and as a vim user support would be nice. (I do not think any other vim bindings should be added, as that's way too opinionated. But basic hjkl support would be nice).

I am really not a fan of duplicating functionality 🤔- My main concern is simplicity - I need to think about this.

In any case, thanks for making gitui. Been using it for a bit and it works nice and fast!

Thank you so much❤️

@data-man
Copy link
Author

@extrawurst

support home/end to jump up/down

Thank you for getting started!
I tested this commit, but the Home and End aren't working.

@extrawurst
Copy link
Owner

I tested this commit, but the Home and End aren't working.

Thanks so much for even trying a build from code!😍
Hooked up my external keyboard now and fixed It 🙈
see 5fc8d72

home/end were easy, the remaining ones (pages/down) will take little longer, since I need to rework some code to allow this. (currently the rendering is IMGUI style and stateless, so I dont know how high the screen area is outside the rendering code. I will figure this out since I could use it for a couple of other things too!

extrawurst pushed a commit that referenced this issue May 10, 2020
extrawurst pushed a commit that referenced this issue May 10, 2020
extrawurst pushed a commit that referenced this issue May 11, 2020
extrawurst pushed a commit that referenced this issue May 11, 2020
@extrawurst
Copy link
Owner

@data-man if you want to try the page up/down should now work in the commit log 😊

extrawurst pushed a commit that referenced this issue May 12, 2020
@data-man
Copy link
Author

@extrawurst Great! Thank you!

Also would be nice to add mouse wheel support in the future.

@extrawurst
Copy link
Owner

home/end/pageUp/pageDown support released as 0.2.3: https://github.com/extrawurst/gitui/releases/tag/v0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants