Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup some stringly typed code #655

Closed
extrawurst opened this issue Apr 21, 2021 · 0 comments · Fixed by #668
Closed

cleanup some stringly typed code #655

extrawurst opened this issue Apr 21, 2021 · 0 comments · Fixed by #668
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.15

Comments

@extrawurst
Copy link
Owner

extrawurst commented Apr 21, 2021 •
edited
Loading

now that rust-lang/git2-rs@ae256db was released we can switch our usage of the diff line types to enum values:
used for diff and line-ops OTOH
@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Apr 21, 2021
@extrawurst extrawurst added this to the v0.15 milestone Apr 21, 2021
wandernauta added a commit to wandernauta/gitui that referenced this issue Apr 25, 2021
@wandernauta
Use git2::DiffLineType enum instead of char values (extrawurst#655)
295ba61 
The DiffLineType enum in asyncgit has fewer variants: it maps context lines and
line types we don't expect to None. This behavior is kept unchanged.

Now calls `.origin_value()` rather than `.origin()` except in one debug log.
@wandernauta wandernauta mentioned this issue Apr 25, 2021
Merged
extrawurst pushed a commit that referenced this issue Apr 25, 2021
@wandernauta
Use git2::DiffLineType enum instead of char values (#668)
c42d369 
closes #655
extrawurst pushed a commit that referenced this issue May 27, 2021
@wandernauta
Use git2::DiffLineType enum instead of char values (#668)
2742cdd 
closes #655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.15
Development

Successfully merging a pull request may close this issue.

Use git2::DiffLineType enum instead of char values (#655) wandernauta/gitui
1 participant
@extrawurst