Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing unstaged JSON causes: out of range integral type conversion attempted #96

Closed
ignatenkobrain opened this issue May 29, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@ignatenkobrain
Copy link
Contributor

Describe the bug

Error: out of range integral type conversion attempted

To Reproduce
Steps to reproduce the behavior:

  1. Open gitui with unstaged json (possibly big enough, I have https://src.fedoraproject.org/extras/pagure_owner_alias.json)
  2. Click on "→" arrow

Expected behavior
gitui should not exit with an error, the json should be shown :)

Desktop (please complete the following information):

  • OS: Fedora
  • Version: 33
@ignatenkobrain ignatenkobrain changed the title Trying to open a JSON in diff causes exit Showing unstaged JSON causes: out of range integral type conversion attempted May 29, 2020
@ignatenkobrain
Copy link
Contributor Author

Just realized that you don't have to open a diff, once you go through unstaged files and hit this json, gitui closes with an error.

@extrawurst extrawurst added the bug Something isn't working label May 29, 2020
@extrawurst
Copy link
Owner

@ignatenkobrain thanks for the report. I fixed the error first but I am still not happy since performance suffers when diffing giant files

@extrawurst
Copy link
Owner

Now that should do. will release a patch version later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants