Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort fuzzy_matcher results based on score #1183

Merged
merged 2 commits into from Apr 24, 2022

Conversation

mark2185
Copy link
Contributor

@mark2185 mark2185 commented Mar 31, 2022

It changes the following:

  • exact matches have a higher priority and are placed first in the results

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Can you give me some pointers regarding how to test this?

I tested it manually, previously by searching files with the pattern gif (in the gitui repo), results such as github/FUNDING.yml were above the ones actually containing gif in its name.

@mark2185 mark2185 force-pushed the feature/sort-fzf-results branch 2 times, most recently from 4a53119 to 9a7cbd8 Compare March 31, 2022 12:03
@extrawurst
Copy link
Owner

good catch! don't you want to add something to the changelog?

@mark2185
Copy link
Contributor Author

mark2185 commented Apr 8, 2022

good catch! don't you want to add something to the changelog?

Sure do! Added an entry under Fixed.

@extrawurst extrawurst merged commit 638d7c2 into extrawurst:master Apr 24, 2022
@extrawurst
Copy link
Owner

Thanks for this contribution 🥳

@mark2185 mark2185 deleted the feature/sort-fzf-results branch April 24, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants