Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display commit description in addition to hash in file view #1380

Merged
merged 1 commit into from Nov 14, 2022

Conversation

alexmaco
Copy link
Contributor

@alexmaco alexmaco commented Oct 6, 2022

It changes the following:

  • displays the commit name besides the hash in the file view

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Owner

extrawurst commented Oct 15, 2022

Screenshot 2022-10-15 at 12 25 39

im not convinced of this yet, this rarely fits the screen. maybe we just introduce a shortcut to open the current commit detail popup from the files component, this will contain the commit desc. aswell

@alexmaco
Copy link
Contributor Author

this rarely fits the screen

There are multiple things that can't be shown fully when the screen is too small to fit them. But most often it fits on a terminal for me.

The main use of this is remembering which commit this is exactly, and by proxy, sometimes which branch. It's easy to forget which commit does the current file view point at, and even the start of the message is usually enough to distinguish between several commits as a mnemonic.

Do you see any substantial downsides to having an at-a-glance disambiguation?

maybe we just introduce a shortcut

Imo there are many shortcuts already, but no consistent model of interaction yet (hence, #1383).

Being able to switch to a commit view would be really nice if it would always work like a toggle, regardless of how the file view was opened, but that would introduce some overlap with the current use of Esc, and some unpredictable (i.e. special-cased) view switching. So off-hand it seems like something that's easier to get wrong than right without some more detailed UX consideration.

@extrawurst
Copy link
Owner

ok lets have a changelog entry and it can be merged

@extrawurst extrawurst added this to the v0.22 milestone Nov 5, 2022
@extrawurst extrawurst merged commit 0f9389c into extrawurst:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants