Checkout commit #1499
Merged
Checkout commit #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
reviewed
Jan 29, 2023
| repo.set_head_detached(commit_hash.into())?; | ||
|
|
||
| if let Err(e) = repo.checkout_head(Some( | ||
| git2::build::CheckoutBuilder::new().force(), |
There was a problem hiding this comment.
this will overwrite changes made to the index, right? I am not sure we want force to be true
There was a problem hiding this comment.
I tested, it in fact will fail with an Err if there are uncommitted changes. se more comments below
extrawurst
reviewed
Jan 29, 2023
extrawurst
requested changes
Jan 29, 2023
| repo.set_head_detached(commit_hash.into())?; | ||
|
|
||
| if let Err(e) = repo.checkout_head(Some( | ||
| git2::build::CheckoutBuilder::new().force(), |
There was a problem hiding this comment.
I tested, it in fact will fail with an Err if there are uncommitted changes. se more comments below
|
Thank you for your comments! I've fixed the code, let me know if more stuff needs fixing. 💪 |
|
Thank you @fralcow |
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
* Add keybind to checkout commit in log view * Extract commit checkout into method * add quckbar hint for checkout commit * add a smoke test * update changelog * show an error in popup --------- Co-authored-by: Omnikar <omnikar5@gmail.com> Co-authored-by: extrawurst <776816+extrawurst@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #983
It changes the following:
I followed the checklist:
make checkwithout errors -- sync::submodules::tests::test_smoke throws an error for me, both in master and my branch:Error { code: -1, klass: 16, message: "the server did not provide a certificate" }. I would appreciate some help fixing this.The PR by the original author went stale, I hope we can add this function in this PR.