-
-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support git commit signing using OpenPGP #1544
Merged
extrawurst
merged 14 commits into
extrawurst:master
from
hendrikmaus:gpg-commit-signing
Mar 24, 2024
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
af397c5
Support git commit signing using OpenPGP
hendrikmaus 798afbc
do not run sign builder doc test
hendrikmaus a3f77ac
Run existing tests inside a container
hendrikmaus 374293a
add workaround for amending signed commits
utkarshgupta137 e92da3d
add workaround for rewording signed commits
utkarshgupta137 2087128
add missing err comment
hendrikmaus bf81abd
remove signing methods switch
hendrikmaus 29cea7a
remove testing files
hendrikmaus 1f720ea
Merge branch 'master' of github.com:extrawurst/gitui into gpg-commit-…
hendrikmaus 7d81738
sign the bytes of the commit buffer instead of utf-8
hendrikmaus 618f208
changelog entry
hendrikmaus a27c7ef
format code
hendrikmaus 3a264d5
support signing initial commit
hendrikmaus a8bb4bb
return both signature and signature_field value from sign
hendrikmaus File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we want to support more than just gpg the third parameter
signature_field
needs to take something out ofsign
which in this case has to begpgsig
but something else for sshThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I very much wish for ssh signing. I don't PGP/GPG but i ssh all the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@damccull this one only adds openpgp; there is another PR that wants to add ssh signing. @extrawurst wants them to adopt the
Sign
trait once this one here is merged though.