Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert clipboard feature on linux to fix static linux binary build #261

Merged
merged 6 commits into from Aug 31, 2020

Conversation

extrawurst
Copy link
Owner

this reverts the new dependency on clipboard and x11 in turn so that static linux binaries can be build again.
we need to look into a different solution later.

closes #259

@extrawurst extrawurst merged commit e5c38e8 into master Aug 31, 2020
@extrawurst extrawurst deleted the musl-build branch August 31, 2020 23:36
@wezm
Copy link
Contributor

wezm commented Aug 31, 2020

One possibility for X11 would be to shell out to xclip or xsel. This is the approach taken by pass and Neovim.

@extrawurst
Copy link
Owner Author

@wezm actually considering this now. I guess there is no way to build against a static version of x11 using musl, right?

@extrawurst
Copy link
Owner Author

@wezm also see here: #258 (comment)

@wezm
Copy link
Contributor

wezm commented Sep 1, 2020

I guess there is no way to build against a static version of x11 using musl, right?

It's possible but probably not with the x11-clipboard crate.The x11 crate (as opposed to the x11-dl variant) statically links by default. So, if this was used instead then it would be possible. However, I think the xsel/xclip option is best if you don't want to have a dependency on X11 directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to execute gitui binary file downloaded from the release page
2 participants