Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add LICENSE file into the sub-crates #94

Merged
merged 1 commit into from
May 28, 2020

Conversation

ignatenkobrain
Copy link
Contributor

Those are released separately on crates.io and they do not contain
LICENSE file now that is required when packaging them in Linux
distributions.

Signed-off-by: Igor Raits i.gnatenko.brain@gmail.com

Those are released separately on crates.io and they do not contain
LICENSE file now that is required when packaging them in Linux
distributions.

Signed-off-by: Igor Raits <i.gnatenko.brain@gmail.com>
@extrawurst
Copy link
Owner

Good point! Thanks for your contribution @ignatenkobrain but I am curious wouldn't it be better to add them as actual files instead of symlinks? I just realise that crates.io takes a snapshot of the crate on publish and I don't even know what it does when there is a symlink in there: https://docs.rs/crate/asyncgit/0.4.0/source/

@ignatenkobrain
Copy link
Contributor Author

@extrawurst as long as you don't try to publish crate from windows machine, it will be fine (many projects are using it this way).

@ignatenkobrain
Copy link
Contributor Author

it will be converted to the real file since cargo will resolve any symlinks when publishing.

@extrawurst
Copy link
Owner

Perfect! Thanks four your input, I did not know that!

@extrawurst extrawurst merged commit 85a3d93 into extrawurst:master May 28, 2020
@ignatenkobrain ignatenkobrain deleted the license branch May 28, 2020 14:13
@extrawurst
Copy link
Owner

@ignatenkobrain did this come up in adding gitui to any particular distro? I am no linux user, I would love to list it in the README if it is part of any linux distro.

@ignatenkobrain
Copy link
Contributor Author

@extrawurst I have a package under review now in Fedora. Once I build it for stable releases, I'll send update to the README :)

@ignatenkobrain
Copy link
Contributor Author

#95 here you go @extrawurst :)

Thanks for working on this project! I found it quite nice and will open few RFEs tomorrow :)

@extrawurst
Copy link
Owner

@ignatenkobrain what is an RFE? 🙈

@ignatenkobrain
Copy link
Contributor Author

Request For Enhancement :)

Basically I miss opening a commit from commit list that can show diff in some nice view. Aka git show, but better. Also searching capabilities in commits are quite limited now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants