Feature/switch different landscape #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiyohome
requested changes
Sep 19, 2023
Assets/Holiday/Controls/LandscapeControl/LandscapeControlPresenter.cs
Outdated
Show resolved
Hide resolved
Assets/Holiday/Controls/LandscapeControl/LandscapePlayers/Image/LandscapeImagePlayer.cs
Outdated
Show resolved
Hide resolved
Assets/Holiday/Screens/GroupSelectionScreen/GroupSelectionScreenPresenter.cs
Outdated
Show resolved
Hide resolved
…om/extreal-dev/Extreal.SampleApp.Holiday into feature/switch-different-landscape
…om/extreal-dev/Extreal.SampleApp.Holiday into feature/switch-different-landscape
kiyohome
requested changes
Sep 29, 2023
kiyohome
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
何の変更を加えましたか？
バーチャル風景を切り替えられる実装を追加した
・バーチャル空間から動画ステージと静止画ステージに切り替えるようにした
・hostだけ切り替えることができるようにした
・再生する動画と静止画はlandscapeConfigから設定することで、S3から配信できるようにした
何を確認しましたか?
実装
テスト
変更影響
レビュアーへのメッセージ