Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

大規模マルチプレイおよびテキストチャットを導入 #23

Merged
merged 49 commits into from Feb 5, 2024
Merged

大規模マルチプレイおよびテキストチャットを導入 #23

merged 49 commits into from Feb 5, 2024

Conversation

sus-taguchi-t
Copy link
Contributor

@sus-taguchi-t sus-taguchi-t commented Dec 27, 2023 •
edited

何の変更を加えましたか？

  • 以下の仕様に変更しました
    • スペースごとにメッセージングを用いた大規模マルチプレイ
    • グループごとにチャット
      • ボイスチャットは P2P のまま
      • テキストチャットは Messaging に変更

何を確認しましたか?

実装

  • 実行時の動きが分かるように、ログ（Error/Warn/Info/Debug）を出力していることを確認しました
  • 静的解析で問題が見つからないことを確認しました

テスト

  • 変更影響がある全てのテストが成功することを確認しました
  • 変更影響があるソースのテストカバレッジが100%になることを確認しました
    • タッチ端末の Web 上でのみ通る以下の 2 点はカバレッジが取れません
      • MultiplayCanvasControllerInput クラス全体
      • NetworkThirdPersonController クラス内の RegisterCurrentDeviceIsTouchDevice メソッド

変更影響

extreal-dev/Extreal.Guide#56

  • GuideのSample Applicationに変更が反映されることを確認しました

レビュアーへのメッセージ

mahaweilu and others added 28 commits November 21, 2023 22:17
@mahaweilu
first commit
420bb14
@mahaweilu
save file
3f15c7a
@sus-taguchi-t
Implement the coexistence of P2P and Massively Multiplayer
c9dc32c
@mahaweilu
save files
5f58a24
@mahaweilu
save files
a201d40
@mahaweilu
show avatars in 2 clients successfully
1fe4451
@mahaweilu
add :listRoom, deleteRoom, p2p fix
b6cd680
@sus-taguchi-t
Modify to enable rough synchronization
fbf9e89
@sus-taguchi-t
Modify to enable detailed synchronization
08ac43f
@sus-taguchi-t
Enable to control whether to send synchronized values on application
1ae4350
@sus-taguchi-t
Devide to each libraries
c0a041a
@sus-taguchi-t
Extract common parts of RedisMessagingTransport between Native and WebGL
fc53b98
@sus-taguchi-t
Implement for WebGL
e57972d
@mahaweilu
add multiplay.messaging
a83b792
@sus-taguchi-t
Enable to transition spaces
f79e51c
@sus-taguchi-t
Enable synchronization of avatar
392c137
@mahaweilu
restore performanceTest
ff3fa6d
@mahaweilu
add eof
d750f22
@sus-taguchi-t
Refactoring
7300446
@sus-taguchi-t
Modify in response to review
6ee4f1c
@sus-taguchi-t
Change DIsconnect method to awaitable
4781e11
@sus-taguchi-t
Organize codes
b35ac49
@sus-taguchi-t
Modify player input
fe9b6b2
@sus-taguchi-t
Modify in response to review
f64fac1
@sus-taguchi-t
Remove Netcode
b4fd5a6
@sus-taguchi-t
Change text chat to one using messaging client
e3cecfd
@sus-taguchi-t
Organize codes
6866d5f
@sus-taguchi-t
Modify so that analyzer's warning does not appear
8a6cff0
mahaweilu
mahaweilu reviewed Dec 27, 2023
View reviewed changes
Assets/Plugins/ParrelSync/ScriptableObjects/ParrelSyncProjectSettings.asset Outdated Show resolved Hide resolved
Assets/WebGLScripts~/package.json Outdated Show resolved Hide resolved
Assets/WebGLScripts~/rollup.config.ts Outdated Show resolved Hide resolved
Packages/manifest.json Outdated Show resolved Hide resolved
Assets/Holiday.PerformanceTest/Extreal.SampleApp.Holiday.PerformanceTest.asmdef Outdated Show resolved Hide resolved
Assets/Holiday/Controls/TextChatControl/TextChatRoom.cs Outdated Show resolved Hide resolved
sus-yoshikane-t
sus-yoshikane-t requested changes Dec 28, 2023
View reviewed changes
Assets/WebGLScripts~/yarn.lock Outdated Show resolved Hide resolved
ProjectSettings/PackageManagerSettings.asset Outdated Show resolved Hide resolved
@mahaweilu mahaweilu mentioned this pull request Jan 23, 2024
Merged
11 tasks
@extreal-dev extreal-dev deleted a comment from mahaweilu Jan 31, 2024
@extreal-dev extreal-dev deleted a comment from mahaweilu Jan 31, 2024
@sus-taguchi-t
Remove max capacity from messaging config
260d8a3
@sus-taguchi-t
Add scripts for Messaging server
7a1afc4
@sus-taguchi-t
Merge remote-tracking branch 'origin/VerUp' into Messaging
6900df8 
# Conflicts:
#	Assets/Holiday/Controls/Common/Multiplay/NetworkManager.prefab
#	Assets/Holiday/Controls/Common/Multiplay/NetworkThirdPersonController.cs
#	Assets/WebGLScripts~/package.json
#	Assets/WebGLScripts~/yarn.lock
#	Assets/packages.config
#	Packages/manifest.json
#	Packages/packages-lock.json
@sus-taguchi-t sus-taguchi-t merged commit bd0724f into develop Feb 5, 2024
@sus-taguchi-t sus-taguchi-t deleted the Messaging branch February 5, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahaweilu mahaweilu mahaweilu left review comments

@kiyohome kiyohome kiyohome approved these changes

@sus-yoshikane-t sus-yoshikane-t sus-yoshikane-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sus-taguchi-t @kiyohome @mahaweilu @sus-yoshikane-t