Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jsoncli and rmtscript.py to python3 #41

Merged
merged 6 commits into from Jul 25, 2018

Conversation

MidgetAteMyMom
Copy link
Contributor

@MidgetAteMyMom MidgetAteMyMom commented Jul 24, 2018

In rmtscript.py, the readline library is also imported but never used. This prevented the script from being used on windows machines but had no obvious advantages.

updated deprecated method call
Updated deprecated name of method raw_input to up-to-date method name input()
In rmtscript.py, the readline library is also imported but never used. This prevented the script from being used on windows machines but had no obvious advantages.
@stewilliams-extr
Copy link
Contributor

This script needs to keep python2 support. Python 2 no longer works and python 3 fails when using the raw_input. A Python version check at the beginning of the script will make this easy to know if your going to use raw_input vs input.

I added a version independent input method to support python 2 and 3
@MidgetAteMyMom
Copy link
Contributor Author

I added a version independet input method to work arround this issue.

@stewilliams-extr
Copy link
Contributor

That fixed the compatibility issues. Thanks for making the changes. It looks like you are pushing a file called "sh.exe.stackdump". If you remove that file from the push everything will be perfect.

https://github.com/extremenetworks/ExtremeScripting/pull/41/files#diff-56ea5a90e7563451eee1c0fb6f33f18c

added .gitignore
This time, the unwanted files should be gone
@stewilliams-extr stewilliams-extr merged commit ac806d6 into extremenetworks:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants