Skip to content

Commit

Permalink
Don't forget to call quit on custom driver
Browse files Browse the repository at this point in the history
  • Loading branch information
route committed Oct 8, 2013
1 parent c37bba4 commit 0707343
Showing 1 changed file with 24 additions and 16 deletions.
40 changes: 24 additions & 16 deletions spec/integration/driver_spec.rb
Expand Up @@ -44,14 +44,18 @@ def session_url(path)
end

it 'supports capturing console.log' do
output = StringIO.new
Capybara.register_driver :poltergeist_with_logger do |app|
Capybara::Poltergeist::Driver.new(app, :phantomjs_logger => output)
end
begin
output = StringIO.new
Capybara.register_driver :poltergeist_with_logger do |app|
Capybara::Poltergeist::Driver.new(app, :phantomjs_logger => output)
end

session = Capybara::Session.new(:poltergeist_with_logger, TestApp)
session.visit('/poltergeist/console_log')
expect(output.string).to include('Hello world')
session = Capybara::Session.new(:poltergeist_with_logger, TestApp)
session.visit('/poltergeist/console_log')
expect(output.string).to include('Hello world')
ensure
session.driver.quit
end
end

# FIXME: It definitely must be fixed on jruby, because all futher tests fail
Expand Down Expand Up @@ -357,15 +361,19 @@ def create_screenshot(file, *args)
end

it 'supports extending the phantomjs world' do
@extended_driver.visit session_url("/poltergeist/requiring_custom_extension")
expect(@extended_driver.body).
to include(%Q%Location: <span id="location">1,-1</span>%)
expect(
@extended_driver.evaluate_script("document.getElementById('location').innerHTML")
).to eq('1,-1')
expect(
@extended_driver.evaluate_script('navigator.geolocation')
).to_not eq(nil)
begin
@extended_driver.visit session_url("/poltergeist/requiring_custom_extension")
expect(@extended_driver.body).
to include(%Q%Location: <span id="location">1,-1</span>%)
expect(
@extended_driver.evaluate_script("document.getElementById('location').innerHTML")
).to eq('1,-1')
expect(
@extended_driver.evaluate_script('navigator.geolocation')
).to_not eq(nil)
ensure
@extended_driver.quit
end
end
end

Expand Down

0 comments on commit 0707343

Please sign in to comment.