Removing force unwrapping in SVGParser #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for these fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussion in #732 I went ahead and removed all force unwrapping from SVGParser. Some of it was safe, and it would never crash. Although, I still think it is a bad practice to use it, so I replaced it with other ways Swift has.
Nevertheless, many of these force unwrappings would actually result in a crash if somebody provided a non-ideal SVG.
I have also added some logging, but I guess it requires a bigger overhaul that is beyond my intention at this moment.
Let me know if you would prefer to do something differently.