OS version availability checks to resolve deprecation warnings #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarunko
reviewed
Oct 15, 2020
Source/svg/SVGParser.swift
Outdated
| @@ -704,7 +704,13 @@ open class SVGParser { | |||
| cleanedHexString = "\(x[0])\(x[0])\(x[1])\(x[1])\(x[2])\(x[2])" | |||
| } | |||
| var rgbValue: UInt32 = 0 | |||
| Scanner(string: cleanedHexString).scanHexInt32(&rgbValue) | |||
| if #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *) { | |||
| if let scannedInt = Scanner(string: cleanedHexString).scanUInt64(representation: .hexadecimal) { | |||
There was a problem hiding this comment.
You can match two conditions into one
if #available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *), let scannedInt = Scanner(string: cleanedHexString).scanUInt64(representation: .hexadecimal)
amarunko
approved these changes
Oct 15, 2020
|
@amarunko the travis-ci didn't kick off to build/test this PR. Does this have to be manually triggered by someone? |
|
Hm, no, Travis worked automatically on this project, need to check |
|
Actually, build passed, I can't find this action on GitHub as before, but it's ok |
|
Hmm interesting. Odd it didn't append details to the PR as travis normally does. Anyway, good to see it's passed automated processes |
|
Thanks! Merged to the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly deprecations in
Scannermethods from iOS 13.0 and one fromCADisplayLink. See image here for warnings when we've included via cocoapods