Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-16 #18

Closed
wants to merge 1 commit into from
Closed

Issue-16 #18

wants to merge 1 commit into from

Conversation

svetzhelev
Copy link

Bugfix for error message 'Modifying state during view update, this will cause undefined behavior'.

@f3dm76
Copy link
Collaborator

f3dm76 commented Feb 27, 2023

Hey @svetzhelevm, thank you for your work. However, are you sure this fix won't change the behaviour? configure function not only sets uiScrollView's value but also sets up some callbacks. Could you please see if there's a way to narrow down the cause of the error message and only limit that, not the whole configure call? Or I can see to that once I have time

@svetzhelev
Copy link
Author

svetzhelev commented Feb 28, 2023

Hey @svetzhelevm, thank you for your work. However, are you sure this fix won't change the behaviour? configure function not only sets uiScrollView's value but also sets up some callbacks. Could you please see if there's a way to narrow down the cause of the error message and only limit that, not the whole configure call? Or I can see to that once I have time
@f3dm76 I do not think it will as you only set the scrollview once and configure it once per instance. Or I am wrong?

@ahbou
Copy link

ahbou commented Apr 6, 2023

Can someone approve this fix please? I see this run time error all the time.

@f3dm76
Copy link
Collaborator

f3dm76 commented Apr 7, 2023

@ahbou Please check out version 0.1.0, should be fixed there, have a great day!

@f3dm76 f3dm76 closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants