Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messenger window toolbar buttons appear garbled #100

Closed
eyalroz opened this issue Aug 12, 2023 · 1 comment
Closed

Messenger window toolbar buttons appear garbled #100

eyalroz opened this issue Aug 12, 2023 · 1 comment
Assignees
@eyalroz
Labels
compatibility resolved-on-development
Milestone
Thunderbird 115 C...

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 12, 2023

On single message windows (not the 3-pane window), our toolbar buttons do show, but - they're garbled. It seems what we're seeing is a squeezing of the 4 different icons in the same png file into just one. Also seeing something similar in the formatting toolbar - but there the icon is doubled: The disabled and non-disabled version. Perhaps TB is ignoring the -moz-image-rect property these days?
@eyalroz eyalroz added this to the Thunderbird 115 Compatibility milestone Aug 12, 2023
@eyalroz eyalroz self-assigned this Aug 12, 2023
@eyalroz eyalroz changed the title Messenger window toolbar buttons now apparently 18x18 Messenger window toolbar buttons appear garbled Aug 12, 2023
@eyalroz
Copy link
Owner Author

eyalroz commented Aug 15, 2023

Even though -moz-image-rect() should have been able to replace -moz-image-region - I couldn't quite get it to work so far, so - switching to an explicit PNG file for each icon.

eyalroz added a commit that referenced this issue Aug 15, 2023
@eyalroz
Fixes #100: No longer using -moz-image-region; using a separate ico…
e172c31 
…n file for each button

* Fixed some missing / erroneous rules for Darwin
* Removed some redundant rules (?)
* Moved non-light-theme specific themes before the light-theme rules

Note: I don't like this change, I would have rather avoided the separate icon files and the highly-verbose CSS.
eyalroz added a commit that referenced this issue Aug 16, 2023
@eyalroz
Fixes #100: No longer using -moz-image-region; using a separate ico…
0b1f8b4 
…n file for each button

* Fixed some missing / erroneous rules for Darwin
* Removed some redundant rules (?)
* Moved non-light-theme specific themes before the light-theme rules

Note: I don't like this change, I would have rather avoided the separate icon files and the highly-verbose CSS.
@eyalroz eyalroz closed this as completed in a8aed3e Sep 1, 2023
eyalroz added a commit that referenced this issue Sep 1, 2023
@eyalroz
Fixes #100: No longer using -moz-image-region; using a separate ico…
39ee332 
…n file for each button

* Fixed some missing / erroneous rules for Darwin
* Removed some redundant rules (?)
* Moved non-light-theme specific themes before the light-theme rules

Note: I don't like this change, I would have rather avoided the separate icon files and the highly-verbose CSS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
compatibility resolved-on-development
Projects
None yet
Milestone
Thunderbird 115 Compatibility
Development

No branches or pull requests
1 participant
@eyalroz