Failing to get the right windows, documents, bodies in some MessageOverlay methods #106
Assignees
Labels
Comments
eyalroz
added a commit
that referenced
this issue
Aug 16, 2023
…ocuments and bodies Note: Some of the code for doing this leaves much to be desired: * It may be possible to avoid passing the window to a wrapper to the `onLoad()` function, and down into various getters * It may be possible to detect when the global window will not have a `tabmail` or `messageBrowser` elements; and perhaps one can conclude apriori that in this case it has a `messagePaneBrowser` * We may be overly protective with the `?.` operators
eyalroz
added a commit
that referenced
this issue
Sep 1, 2023
…ocuments and bodies Note: Some of the code for doing this leaves much to be desired: * It may be possible to avoid passing the window to a wrapper to the `onLoad()` function, and down into various getters * It may be possible to detect when the global window will not have a `tabmail` or `messageBrowser` elements; and perhaps one can conclude apriori that in this case it has a `messagePaneBrowser` * We may be overly protective with the `?.` operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code in methods such as
gatherParameters(),forceDirection()andcycleDirectionSettings(), we use the messagePane, which we locate using TB-102-compatible code - that can't be used in TB 115. Instead, let's use the new "about Message" mechanism; it can be used like so:The text was updated successfully, but these errors were encountered: