Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

messengercompose.xml event handler for compose-window-init doesn't fire #110

Closed
eyalroz opened this issue Aug 19, 2023 · 2 comments
Closed

messengercompose.xml event handler for compose-window-init doesn't fire #110

eyalroz opened this issue Aug 19, 2023 · 2 comments
Assignees
@eyalroz
Labels
bug Something isn't working compatibility resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 19, 2023

New message compositions currently start in LTR mode, regardless of what the BiDi Mail UI preference said. The preference application has apparently at some point either been skipped or now applies to the wrong object etc. No exceptions or errors logged though!
@eyalroz eyalroz added bug Something isn't working compatibility labels Aug 19, 2023
@eyalroz eyalroz self-assigned this Aug 19, 2023
@eyalroz eyalroz changed the title Failing to apply new message direction preference messengercompose.xml event handler for compose-window-init doesn't fire Aug 28, 2023
@eyalroz
Copy link
Owner Author

eyalroz commented Aug 28, 2023

So, digging (slightly) deeper: It seems that our event handler, BiDiMailUI.Composition.onInit(), which is registered to fire on event "compose-window-init" - doesn't fire like it used to in v102. Why? I don't know!

@eyalroz
Copy link
Owner Author

eyalroz commented Sep 1, 2023

It turns on the "WindowListener" extension loader calls the chrome injector script after compose-window-init has already fired.

... but given that this is the case - we can simply run the event handler code from the chrome injector!

@eyalroz eyalroz closed this as completed in 345c847 Sep 1, 2023
eyalroz added a commit that referenced this issue Sep 1, 2023
@eyalroz
Fixes #110: No longer onInit() code to event:
353ae04 
* Removed: `BiDiMailUI.Composition.onInit()`
* Running the code dependent on `compose-window-init` directly from the WindowListener chrome injector, as it is executed _after_ the event has already fired
@eyalroz eyalroz mentioned this issue Sep 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug Something isn't working compatibility resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz