Attempt to CreateXULElement for adding a style rule fails #31
Assignees
Labels
Comments
eyalroz
pushed a commit
that referenced
this issue
Sep 2, 2020
Revamped the helper function for adding CSS rules to the document via an ad-hoc stylesheet: * Renamed `addMessageStyleRules` -> `ensureMessageStyleRulesAdded` * Now giving a specific ID to the added rules * No longer adding the style rules if they already exist (protecting against repeat invocations) * Now using `createElement()` rather than `createXULElement()`.
eyalroz
pushed a commit
that referenced
this issue
Sep 2, 2020
Revamped the helper function for adding CSS rules to the document via an ad-hoc stylesheet: * Renamed `addMessageStyleRules` -> `ensureMessageStyleRulesAdded` * Now giving a specific ID to the added rules * No longer adding the style rules if they already exist (protecting against repeat invocations) * Now using `createElement()` rather than `createXULElement()`.
eyalroz
pushed a commit
that referenced
this issue
Sep 5, 2020
Revamped the helper function for adding CSS rules to the document via an ad-hoc stylesheet: * Renamed `addMessageStyleRules` -> `ensureMessageStyleRulesAdded` * Now giving a specific ID to the added rules * No longer adding the style rules if they already exist (protecting against repeat invocations) * Now using `createElement()` rather than `createXULElement()`.
eyalroz
pushed a commit
that referenced
this issue
Sep 5, 2020
Revamped the helper function for adding CSS rules to the document via an ad-hoc stylesheet: * Renamed `addMessageStyleRules` -> `ensureMessageStyleRulesAdded` * Now giving a specific ID to the added rules * No longer adding the style rules if they already exist (protecting against repeat invocations) * Now using `createElement()` rather than `createXULElement()`.
eyalroz
pushed a commit
that referenced
this issue
Sep 5, 2020
Revamped the helper function for adding CSS rules to the document via an ad-hoc stylesheet: * Renamed `addMessageStyleRules` -> `ensureMessageStyleRulesAdded` * Now giving a specific ID to the added rules * No longer adding the style rules if they already exist (protecting against repeat invocations) * Now using `createElement()` rather than `createXULElement()`.
eyalroz
pushed a commit
that referenced
this issue
Sep 5, 2020
Revamped the helper function for adding CSS rules to the document via an ad-hoc stylesheet: * Renamed `addMessageStyleRules` -> `ensureMessageStyleRulesAdded` * Now giving a specific ID to the added rules * No longer adding the style rules if they already exist (protecting against repeat invocations) * Now using `createElement()` rather than `createXULElement()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We used to create a style element for adding to a message being composed, like so:
but this no longer works; possibly, the contentDocument is no longer a XUL document and can't create XUL elements. Instead, it has to be an HTML style element. Also, let's make this code look a bit like the stylesheet link injection function.
The text was updated successfully, but these errors were encountered: