Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TB 115 doesn't like our uses of this in BiDiMailUI.Strings functions #92

Closed
eyalroz opened this issue Aug 10, 2023 · 0 comments
Closed

TB 115 doesn't like our uses of this in BiDiMailUI.Strings functions #92

eyalroz opened this issue Aug 10, 2023 · 0 comments
Assignees
@eyalroz
Labels
compatibility resolved-on-development
Milestone
Thunderbird 115 C...

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 10, 2023 •
edited

TB 115 is complaining about calling sibling functions within BiDiMailUI.Strings using this.funcName(). So, let's use the full name, BiDiMailUI.Strings.funcName() instead.
@eyalroz eyalroz self-assigned this Aug 10, 2023
@eyalroz eyalroz added this to the Thunderbird 115 Compatibility milestone Aug 10, 2023
eyalroz added a commit that referenced this issue Aug 10, 2023
@eyalroz
Fixes #92: Using fullly-qualified object names instead of this in s…
5b665cd 
…ome calls to `BiDiMailUI.Strings` functions
eyalroz added a commit that referenced this issue Aug 11, 2023
@eyalroz
Fixes #92: Using fullly-qualified object names instead of this in s…
2a0063b 
…ome calls to `BiDiMailUI.Strings` functions
@eyalroz eyalroz closed this as completed in 2a70185 Sep 1, 2023
eyalroz added a commit that referenced this issue Sep 1, 2023
@eyalroz
Fixes #92: Using fullly-qualified object names instead of this in s…
f02ef87 
…ome calls to `BiDiMailUI.Strings` functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
compatibility resolved-on-development
Projects
None yet
Milestone
Thunderbird 115 Compatibility
Development

No branches or pull requests
1 participant
@eyalroz