Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more robust about setting cMCParams.messageSubject #95

Closed
eyalroz opened this issue Aug 10, 2023 · 0 comments
Closed

Be more robust about setting cMCParams.messageSubject #95

eyalroz opened this issue Aug 10, 2023 · 0 comments
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Aug 10, 2023

Let's go the extra mile to ensure cMCParams.messageSubject is non-null (e.g. in case we couldn't find the subject box); and at the same time - let's not do that work later, when trying to use cMCParams in fixLoadedMessageCharsetIssues().

At the same time - let's be defensive and check for nullness of cMCParams.messageSubject before using it.
@eyalroz eyalroz added the task label Aug 10, 2023
eyalroz added a commit that referenced this issue Aug 11, 2023
@eyalroz
Fixes #95: More robust handling of cMC.messageSubject - both settin…
79984b0 
…g it and using it
eyalroz added a commit that referenced this issue Aug 11, 2023
@eyalroz
Fixes #95: More robust handling of cMC.messageSubject - both settin…
5aa1c2c 
…g it and using it
@eyalroz eyalroz closed this as completed in f673e9c Sep 1, 2023
eyalroz added a commit that referenced this issue Sep 1, 2023
@eyalroz
Fixes #95: More robust handling of cMC.messageSubject - both settin…
7edf1ee 
…g it and using it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz