Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we move detail_:: code and/or implementations to separate files? #166

Open
eyalroz opened this issue Apr 1, 2020 · 0 comments
Open
Labels

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 1, 2020

A lot of the wrapper code is located by now within detail:: sub-namespaces, interspersed among the actual, intended-for-use, functions. Additionally, a lot of the implementations of non-detail:: functions are already separated from the declarations, because they require the definitions of wrapper classes which the function declaration does not depend on (multi_header_impls.hpp).

We could, in theory:

  1. Move all detail:: code into separate files within a detail subdirectory (with careful planning to work around dependencies with the non-detail file, e.g. type definitions.
  2. Move all implementations to different files (breaking up multi_wrapper_impls.hpp.

But I'm not sure this is all worth it.

eyalroz pushed a commit that referenced this issue Jun 5, 2020
* Renamed: `kernel_launch.cu` -> `kernek_launch.hpp`
@eyalroz eyalroz changed the title Should we move detail:: code and/or implementations to separate files? Should we move detail_:: code and/or implementations to separate files? Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant