Correct link to CUDA::nvToolsExt of target nvtx

[codecircuit]

We should link to the CUDA nvtx library here. It is sufficient to change this line to

target_link_libraries(nvtx PRIVATE Threads::Threads CUDA::nvToolsExt)

[eyalroz]

Well, CUDA::nvToolsExt should be a public dependency, shouldn't it?

And, come to think of it... shouldn't the threads dependency be public too?

[codecircuit]

It should not be PUBLIC because the header nvtx/profiling.hpp, which defines the INTERFACE of target cuda-api-wrappers::nvtx does not include any header of Threads::Threads or CUDA::nvToolsExt. If a target is linked to cuda-api-wrappers::nvtx the libraries of Threads::Threads and CUDA::nvToolsExt are added at the linking stage, which is sufficient.

[eyalroz]

. If a target is linked to cuda-api-wrappers::nvtx the libraries of Threads::Threads and CUDA::nvToolsExt are added at the linking stage, which is sufficient.

But for them to be added, shouldn't the dependency be PUBLIC? Otherwise, I'm misinterpreting PRIVATE and PUBLIC.

[codecircuit]

This post explains it pretty well.