Possible Improper Use of Lock Guard

[DeveloperPaul123]

In profiling.cpp, the lock_guard variables are not named. My understanding is that this means they will be destroyed immediately which is probably not the intention for the RAII objects.

Example:

void point(const ::std::string& description, color_t color)
{
	::std::lock_guard<::std::mutex> { detail_::profiler_mutex };
	// logging?
	nvtxEventAttributes_t eventAttrib = {0};
	eventAttrib.version = NVTX_VERSION;
	eventAttrib.size = NVTX_EVENT_ATTRIB_STRUCT_SIZE;
	eventAttrib.colorType = NVTX_COLOR_ARGB;
	eventAttrib.color = color;
	eventAttrib.messageType = NVTX_MESSAGE_TYPE_ASCII;
	eventAttrib.message.ascii = description.c_str();
	nvtxMarkEx(&eventAttrib);
}

This was caught by a clang warning.

[eyalroz]

My understanding is that this means they will be destroyed immediately

Are you sure? ... hmm, that clang warning seems to suggest that might be the case. Weird.