Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't launch wrapped kernels on devices other than the wrapper's #288

Closed
eyalroz opened this issue Dec 13, 2021 · 0 comments
Closed

Don't launch wrapped kernels on devices other than the wrapper's #288

eyalroz opened this issue Dec 13, 2021 · 0 comments
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Dec 13, 2021

With #186, we have made wrapped kernels be associated with a specific device. While I'm having some second thoughts about that, I haven't decided to undo that decision. However - the launch functions currently ignore that association - as the pointer can be used to enqueue execution on another device altogether. We need to enforce the restriction somehow.
@eyalroz eyalroz added the bug label Dec 13, 2021
eyalroz added a commit that referenced this issue Dec 13, 2021
@eyalroz
Simplification of the launch wrapping code + fixes #288 by checking w…
1964c14 
…rapped-kernel-vs-stream device match.
eyalroz added a commit that referenced this issue Dec 13, 2021
@eyalroz
Simplification of the launch wrapping code + fixes #288 by checking w…
c58c423 
…rapped-kernel-vs-stream device match.
eyalroz added a commit that referenced this issue Dec 13, 2021
@eyalroz
Simplification of the launch wrapping code + fixes #288 by checking w…
b3305c4 
…rapped-kernel-vs-stream device match.
eyalroz added a commit that referenced this issue Dec 14, 2021
@eyalroz
Simplification of the launch wrapping code + fixes #288 by checking w…
b153aa2 
…rapped-kernel-vs-stream device match.
eyalroz added a commit that referenced this issue Dec 19, 2021
@eyalroz
Simplification of the launch wrapping code + fixes #288 by checking w…
9856cd2 
…rapped-kernel-vs-stream device match.
eyalroz added a commit that referenced this issue Dec 28, 2021
@eyalroz
Simplification of the launch wrapping code + fixes #288 by checking w…
58a2983 
…rapped-kernel-vs-stream device match.
eyalroz added a commit that referenced this issue Jan 14, 2022
@eyalroz
Simplification of the launch wrapping code + fixes #288 by checking w…
86b13ad 
…rapped-kernel-vs-stream device match.
@eyalroz eyalroz closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz