Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wrap() for device_t's #289

Closed
eyalroz opened this issue Dec 13, 2021 · 0 comments
Closed

Use wrap() for device_t's #289

eyalroz opened this issue Dec 13, 2021 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Dec 13, 2021

Let's be uniform with the construction of our wrapper classes, and have device_t's be wrap()'ed as well.
@eyalroz eyalroz added the task label Dec 13, 2021
@eyalroz eyalroz self-assigned this Dec 13, 2021
eyalroz added a commit that referenced this issue Dec 13, 2021
@eyalroz
Fixes #289 - now construction device_t's using `device::detail_::wr…
e8f6348 
…ap()`. Also - no longer using the silly `wrapping_construction` tag - which we didn't need anyway.
eyalroz added a commit that referenced this issue Dec 13, 2021
@eyalroz
Fixes #289 - now construction device_t's using `device::detail_::wr…
d8021fe 
…ap()`. Also - no longer using the silly `wrapping_construction` tag - which we didn't need anyway.
eyalroz added a commit that referenced this issue Dec 13, 2021
@eyalroz
Fixes #289 - now construction device_t's using `device::detail_::wr…
374fae9 
…ap()`. Also - no longer using the silly `wrapping_construction` tag - which we didn't need anyway.
eyalroz added a commit that referenced this issue Dec 14, 2021
@eyalroz
Fixes #289 - now construction device_t's using `device::detail_::wr…
8242add 
…ap()`. Also - no longer using the silly `wrapping_construction` tag - which we didn't need anyway.
eyalroz added a commit that referenced this issue Dec 19, 2021
@eyalroz
Fixes #289 - now construction device_t's using `device::detail_::wr…
0cee353 
…ap()`. Also - no longer using the silly `wrapping_construction` tag - which we didn't need anyway.
eyalroz added a commit that referenced this issue Dec 28, 2021
@eyalroz
Fixes #289 - now construction device_t's using `device::detail_::wr…
9acf3ac 
…ap()`. Also - no longer using the silly `wrapping_construction` tag - which we didn't need anyway.
eyalroz added a commit that referenced this issue Jan 14, 2022
@eyalroz
Fixes #289 - now construction device_t's using `device::detail_::wr…
89c4202 
…ap()`. Also - no longer using the silly `wrapping_construction` tag - which we didn't need anyway.
@eyalroz eyalroz closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz