Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking CUDA_VERSION instead of CUDART_VERSION #300

Closed
eyalroz opened this issue Feb 7, 2022 · 0 comments
Closed

Checking CUDA_VERSION instead of CUDART_VERSION #300

eyalroz opened this issue Feb 7, 2022 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 7, 2022

When adding support for stream attribute copying, getting and setting, I introduced a minimum CUDA runtime API version check, at compile time - but using the wrong preprocessor define: CUDA_VERSION instead of CUDART_VERSION. That means the check will just fail, always.
@eyalroz eyalroz added the bug label Feb 7, 2022
@eyalroz eyalroz self-assigned this Feb 7, 2022
eyalroz added a commit that referenced this issue Feb 7, 2022
@eyalroz
Fixes #299, #300; regards #223:
9f8a983 
* Now properly checking CUDA runtime library header's API version with `CUDART_VERSION` rather than `CUDA_VERSION`.
* Using `stream::handle()` rather than the outdated `stream::id()` when copying stream attributes.
@eyalroz eyalroz closed this as completed Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz