Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential failure to set context when recording an event #314

Closed
eyalroz opened this issue Apr 13, 2022 · 1 comment
Closed

Potential failure to set context when recording an event #314

eyalroz opened this issue Apr 13, 2022 · 1 comment

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 13, 2022

In cuda::event::record(), we're currently not setting the context. This may be ok, but let's be on the safe side.

@eyalroz eyalroz added the bug label Apr 13, 2022
@eyalroz eyalroz changed the title Failure to set context when recording an event Potential failure to set context when recording an event Apr 13, 2022
@eyalroz eyalroz added task bug and removed bug labels Apr 13, 2022
@eyalroz
Copy link
Owner Author

eyalroz commented Apr 13, 2022

Well, turns out it may not be ok after all.

eyalroz added a commit that referenced this issue Apr 13, 2022
…Also,

* A scoped context setter variable was mis-named as a device setter (probably forgot to rename it when making the big switch to being driver-based).
* Rephrased an error message regarding enqueuing an event on a stream in another context.
eyalroz added a commit that referenced this issue Apr 16, 2022
…(e.g. on a stream). Also,

* Defined an `event::detail_::flags_t` type.
* A scoped context setter variable was mis-named as a device setter (probably forgot to rename it when making the big switch to being driver-based).
* Rephrased an error message regarding enqueuing an event on a stream in another context.
@eyalroz eyalroz closed this as completed in 2031ff5 May 9, 2022
eyalroz added a commit that referenced this issue Jun 20, 2022
…(e.g. on a stream). Also,

* Defined an `event::detail_::flags_t` type.
* A scoped context setter variable was mis-named as a device setter (probably forgot to rename it when making the big switch to being driver-based).
* Rephrased an error message regarding enqueuing an event on a stream in another context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant