Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module::create missing when only including runtime_api.hpp #320

Closed
eyalroz opened this issue Apr 21, 2022 · 0 comments
Closed

module::create missing when only including runtime_api.hpp #320

eyalroz opened this issue Apr 21, 2022 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 21, 2022

Unfortunately, it seems we need module::create even which only using the runtime-API-originating headers:

In file included from src/cuda/api/multi_wrapper_impls/device.hpp:21,
                 from src/cuda/runtime_api.hpp:45,
                 from examples/other/runtime_api_header_collection.cpp:1:
src/cuda/api/multi_wrapper_impls/../module.hpp:245:10: error: ‘cuda::module_t cuda::module::detail_::create(const cuda::context_t&, const void*, Creator) [with Creator = cuda::module::detail_::create(const cuda::context_t&, const void*, const cuda::link::options_t&)::<lambda(CUmod_st*&, const void*)>]’, declared using local type ‘cuda::module::detail_::create(const cuda::context_t&, const void*, const cuda::link::options_t&)::<lambda(CUmod_st*&, const void*)>’, is used but never defined [-fpermissive]
  245 | module_t create(const context_t& context, const void* module_data, Creator creator_function);
      |          ^~~~~~
src/cuda/api/multi_wrapper_impls/../module.hpp:245:10: error: ‘cuda::module_t cuda::module::detail_::create(const cuda::context_t&, const void*, Creator) [with Creator = cuda::module::detail_::create(const cuda::context_t&, const void*)::<lambda(CUmod_st*&, const void*)>]’, declared using local type ‘cuda::module::detail_::create(const cuda::context_t&, const void*)::<lambda(CUmod_st*&, const void*)>’, is used but never defined [-fpermissive]
make[3]: *** [examples/CMakeFiles/runtime_api_header_collection.dir/build.make:76: examples/CMakeFiles/runtime_api_header_collection.dir/other/runtime_api_header_collection.cpp.o] Error 1

Let's do something about that - either move the use elsewhere, or add the header implementing the function... :-(

@eyalroz eyalroz added the bug label Apr 21, 2022
@eyalroz eyalroz self-assigned this Apr 21, 2022
eyalroz added a commit that referenced this issue Apr 21, 2022
…ude module-related headers from `runtime_api.hpp`.

* Moved the use of `module::create` from `multi_wrapper_impls/context.hpp` into `multi_wrapper_impls/module.hpp`
* Dropped inclusion of `module.hpp` from some `multi_wrapper_impls` files
@eyalroz eyalroz closed this as completed in 899ef79 May 9, 2022
eyalroz added a commit that referenced this issue Jun 20, 2022
…ude module-related headers from `runtime_api.hpp`.

* Moved the use of `module::create` from `multi_wrapper_impls/context.hpp` into `multi_wrapper_impls/module.hpp`
* Dropped inclusion of `module.hpp` from some `multi_wrapper_impls` files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant