Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid MSVC compiler warnings #339

Closed
eyalroz opened this issue May 27, 2022 · 0 comments
Closed

Avoid MSVC compiler warnings #339

eyalroz opened this issue May 27, 2022 · 0 comments
Assignees
@eyalroz
Labels
ms-windows Related to the Microsoft Windows operating system resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented May 27, 2022

Some MSVC compiler warnings are triggered by recent(ish) changes: Implicit type conversion, and forward-declaring a struct as a class. Let's fix them.
@eyalroz eyalroz added the task label May 27, 2022
@eyalroz eyalroz self-assigned this May 27, 2022
eyalroz added a commit that referenced this issue May 27, 2022
@eyalroz
Fixes #339: Addresses some MSVC compiler warnings.
3d8e406
@eyalroz eyalroz added ms-windows Related to the Microsoft Windows operating system resolved-on-development labels May 27, 2022
eyalroz added a commit that referenced this issue May 29, 2022
@eyalroz
Fixes #339: Addresses some MSVC compiler warnings.
b0b4134
eyalroz added a commit that referenced this issue Jun 2, 2022
@eyalroz
Fixes #339: Addresses some MSVC compiler warnings.
0868e8c
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #339: Addresses some MSVC compiler warnings.
b0028b1
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #339: Addresses some MSVC compiler warnings.
c2c9d3f
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #339: Addresses some MSVC compiler warnings.
8eb6474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
ms-windows Related to the Microsoft Windows operating system resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz