Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy classes must be move-assignable #356

Closed
eyalroz opened this issue Jun 5, 2022 · 0 comments
Closed

proxy classes must be move-assignable #356

eyalroz opened this issue Jun 5, 2022 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 5, 2022 •
edited

We must be able to pass the proxy classes around easily. They must therefore all be at least move-assignable, with ownership and primary context reference count unit preservation.

As for copy-assignment... maybe for devices, since they don't ever get created. But for the other proxies, I think the policy should be move-assignment only (and use references instead of copying).
@eyalroz eyalroz added the bug label Jun 5, 2022
@eyalroz eyalroz self-assigned this Jun 5, 2022
@eyalroz eyalroz changed the title module_t must be assignable proxy classes must be assignable Jun 5, 2022
@eyalroz eyalroz changed the title proxy classes must be assignable proxy classes must be at least move-assignable Jun 5, 2022
@eyalroz eyalroz changed the title proxy classes must be at least move-assignable proxy classes must be move-assignable Jun 5, 2022
eyalroz added a commit that referenced this issue Jun 5, 2022
@eyalroz
Fixes #357, #356: Implement, remove and update assignment operators a…
1fe94f3 
…s necessary

* Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator.
* Made sure all (relevant) proxies have no copy-assignment operator.
* Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`.
* primary context assignment operators now actually return primary context references...
eyalroz added a commit that referenced this issue Jun 5, 2022
@eyalroz
Fixes #357, #356: Implement, remove and update assignment operators a…
c19edca 
…s necessary

* Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator.
* Made sure all (relevant) proxies have no copy-assignment operator.
* Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`.
* primary context assignment operators now actually return primary context references...
eyalroz added a commit that referenced this issue Jun 6, 2022
@eyalroz
Fixes #357, #356: Implement, remove and update assignment operators a…
4b50a92 
…s necessary

* Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator.
* Made sure all (relevant) proxies have no copy-assignment operator.
* Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`.
* primary context assignment operators now actually return primary context references...
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #357, #356: Implement, remove and update assignment operators a…
39fe2eb 
…s necessary

* Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator.
* Made sure all (relevant) proxies have no copy-assignment operator.
* Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`.
* primary context assignment operators now actually return primary context references...
@eyalroz eyalroz closed this as completed Jun 20, 2022
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #357, #356: Implement, remove and update assignment operators a…
58a8ef6 
…s necessary

* Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator.
* Made sure all (relevant) proxies have no copy-assignment operator.
* Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`.
* primary context assignment operators now actually return primary context references...
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #357, #356: Implement, remove and update assignment operators a…
7400e70 
…s necessary

* Made sure all (relevant) proxies have a (`noexcept`) move-assignment operator.
* Made sure all (relevant) proxies have no copy-assignment operator.
* Ensured move assignment operators regard all members, including `hold_pc_refcount_unit`.
* primary context assignment operators now actually return primary context references...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz