Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the language dialect is "set" to an empty/null string - unset it #361

Closed
eyalroz opened this issue Jun 6, 2022 · 0 comments
Closed

If the language dialect is "set" to an empty/null string - unset it #361

eyalroz opened this issue Jun 6, 2022 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 6, 2022

The compilation options should treat an empty/null C++ language dialect string as a request to unset the language dialog.
@eyalroz eyalroz added the task label Jun 6, 2022
@eyalroz eyalroz self-assigned this Jun 6, 2022
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #361, #362:
a986cfd 
* Interpret setting language dialect to an empty/null string as clearing the dialect.
* Add a `clear_language_dialect()` method to `rtc::compilation_options_t`.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #361, #362:
50facab 
* Interpret setting language dialect to an empty/null string as clearing the dialect.
* Add a `clear_language_dialect()` method to `rtc::compilation_options_t`.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #361, #362:
7d4057b 
* Interpret setting language dialect to an empty/null string as clearing the dialect.
* Add a `clear_language_dialect()` method to `rtc::compilation_options_t`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz