Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module_t::get_kernel() taking a string #365

Closed
eyalroz opened this issue Jun 8, 2022 · 0 comments
Closed

Add module_t::get_kernel() taking a string #365

eyalroz opened this issue Jun 8, 2022 · 0 comments
Assignees
@eyalroz
Labels
enhancement resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 8, 2022

We should allow users to pass either a const char* or an std::string to `module_t::get_kernel().
@eyalroz eyalroz self-assigned this Jun 8, 2022
eyalroz added a commit that referenced this issue Jun 8, 2022
@eyalroz
Fixes #365: Add module_t::get_kernel() string variant
b52833d 
Theire is now a variant of `module_t::get_kernel()` which takes
a `const std::string&`.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #365: Add module_t::get_kernel() string variant
7c94801 
Theire is now a variant of `module_t::get_kernel()` which takes
a `const std::string&`.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #365: Add module_t::get_kernel() string variant
312649f 
Theire is now a variant of `module_t::get_kernel()` which takes
a `const std::string&`.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #365: Add module_t::get_kernel() string variant
17d944b 
Theire is now a variant of `module_t::get_kernel()` which takes
a `const std::string&`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
enhancement resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz