Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary context activation error in p2pBandwidthLatencyTest #368

Closed
eyalroz opened this issue Jun 10, 2022 · 0 comments
Closed

Primary context activation error in p2pBandwidthLatencyTest #368

eyalroz opened this issue Jun 10, 2022 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 10, 2022

In the p2pBandwidthLatencyTest example, we are failing to ensure that the primary contexts are active when releasing the allocations on those contexts.
@eyalroz eyalroz added the bug label Jun 10, 2022
@eyalroz eyalroz self-assigned this Jun 10, 2022
eyalroz added a commit that referenced this issue Jun 10, 2022
@eyalroz
Fixes #368: Ensure primary contexts are alive in `p2pBandwidthLatency…
2cc2ced 
…Test`.

* Also, added a comments explaining the difficulty of having to maintain the primary contexts alive.
* Changed the order of destruction of streams and allocated `unique_ptr`s, so that the streams - which hold PC refcount units.
eyalroz added a commit that referenced this issue Jun 10, 2022
@eyalroz
Fixes #368: Ensure primary contexts are alive in `p2pBandwidthLatency…
02aa976 
…Test`.

* Also, added a comments explaining the difficulty of having to maintain the primary contexts alive.
* Changed the order of destruction of streams and allocated `unique_ptr`s, so that the streams - which hold PC refcount units.
eyalroz added a commit that referenced this issue Jun 10, 2022
@eyalroz
Fixes #368: Ensure primary contexts are alive in `p2pBandwidthLatency…
febf572 
…Test`.

* Also, added a comments explaining the difficulty of having to maintain the primary contexts alive.
* Changed the order of destruction of streams and allocated `unique_ptr`s, so that the streams - which hold PC refcount units.
eyalroz added a commit that referenced this issue Jun 11, 2022
@eyalroz
Fixes #368: Ensure primary contexts are alive in `p2pBandwidthLatency…
944c4ab 
…Test`.

* Also, added a comments explaining the difficulty of having to maintain the primary contexts alive.
* Changed the order of destruction of streams and allocated `unique_ptr`s, so that the streams - which hold PC refcount units.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #368: Ensure primary contexts are alive in `p2pBandwidthLatency…
b40a2a4 
…Test`.

* Also, added a comments explaining the difficulty of having to maintain the primary contexts alive.
* Changed the order of destruction of streams and allocated `unique_ptr`s, so that the streams - which hold PC refcount units.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #368: Ensure primary contexts are alive in `p2pBandwidthLatency…
3630c18 
…Test`.

* Also, added a comments explaining the difficulty of having to maintain the primary contexts alive.
* Changed the order of destruction of streams and allocated `unique_ptr`s, so that the streams - which hold PC refcount units.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #368: Ensure primary contexts are alive in `p2pBandwidthLatency…
872fab3 
…Test`.

* Also, added a comments explaining the difficulty of having to maintain the primary contexts alive.
* Changed the order of destruction of streams and allocated `unique_ptr`s, so that the streams - which hold PC refcount units.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz