Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More launch_config_builder tweaks #374

Closed
eyalroz opened this issue Jun 18, 2022 · 0 comments
Closed

More launch_config_builder tweaks #374

eyalroz opened this issue Jun 18, 2022 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jun 18, 2022 •
edited

  • Make the grid-dims settings methods the same as the block-dims settings methods.
  • Accept just 1 and just 2 dimensions when setting dimension triplets (grid, block and overall)
  • No more set_... methods for dimensions.
@eyalroz eyalroz added the task label Jun 18, 2022
@eyalroz eyalroz self-assigned this Jun 18, 2022
eyalroz added a commit that referenced this issue Jun 18, 2022
@eyalroz
Fixes #374: More launch_config_builder tweaks:
d762d4c 
* Make the grid-dims settings methods the same as the block-dims settings methods
* Accept just 1 and just 2 dimensions when setting dimension triplets (grid, block and overall)
eyalroz added a commit that referenced this issue Jun 18, 2022
@eyalroz
Fixes #374: More launch_config_builder tweaks:
0bd188a 
* Make the grid-dims settings methods the same as the block-dims settings methods
* Accept just 1 and just 2 dimensions when setting dimension triplets (grid, block and overall)
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #374: More launch_config_builder tweaks:
2c5b1fe 
* Make the grid-dims settings methods the same as the block-dims settings methods
* Accept just 1 and just 2 dimensions when setting dimension triplets (grid, block and overall)
* No more `set_`... methods for dimensions.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #374: More launch_config_builder tweaks:
23d1f0e 
* Make the grid-dims settings methods the same as the block-dims settings methods
* Accept just 1 and just 2 dimensions when setting dimension triplets (grid, block and overall)
* No more `set_`... methods for dimensions.
eyalroz added a commit that referenced this issue Jun 20, 2022
@eyalroz
Fixes #374: More launch_config_builder tweaks:
58bc1dd 
* Make the grid-dims settings methods the same as the block-dims settings methods
* Accept just 1 and just 2 dimensions when setting dimension triplets (grid, block and overall)
* No more `set_`... methods for dimensions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz