Accept vectors of std::strings for setting NVRTC definition terms and values #403
Assignees
Comments
eyalroz
added a commit
that referenced
this issue
Sep 10, 2022
* Added ability to add a single named header * Reduced the number of `add_headers()` and `set_headers()` function variants, so that the user calls a templated version and the type is determined autogneioammtl * Moved some add_headers() calls into a proptecte name=
eyalroz
added a commit
that referenced
this issue
Sep 10, 2022
* Added ability to add a single named header to a program * Reduced the number of `add_headers()` and `set_headers()` member variants, so that the user calls a templated version and the type is determined by the user's choice of arguments * Made some `add_headers()` members protected, and suffixed with an `_` - the public variants call them
eyalroz
added a commit
that referenced
this issue
Sep 10, 2022
* Added ability to add a single named header to a program * Reduced the number of `add_headers()` and `set_headers()` member variants, so that the user calls a templated version and the type is determined by the user's choice of arguments * Made the lowest building-blocks of header-adding protected members, which the public variants call - for easier handling of types and catching of inappropriate argument type errors
This comment was marked as outdated.
This comment was marked as outdated.
eyalroz
added a commit
that referenced
this issue
Sep 10, 2022
* Added ability to add a single named header to a program * Reduced the number of `add_headers()` and `set_headers()` member variants, so that the user calls a templated version and the type is determined by the user's choice of arguments * Made the lowest building-blocks of header-adding protected members, which the public variants call - for easier handling of types and catching of inappropriate argument type errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We already have multiple variants of
set_headers()andadd_headers()implemented. However - those templated variants which take containers or container pairs assume the element type is a constant C-style string of constant characters (const char* const). What if the user has vectors ofstd::strings? It's a legitimate scenario... let' cater to it.The text was updated successfully, but these errors were encountered: