optional fixes vis-a-vis later C++ standard versions #415
Assignees
Labels
Comments
eyalroz
added a commit
that referenced
this issue
Oct 6, 2022
* Aligned `poor_mans_optional<T>` reset/clear method with the standard library `optional<T>`'s method * A few other tweaks in `poor_mans_optional<T>` * Now using `cuda::optional<T>` in the launch config builder class, rather than forcing the use of `poor_mans_optional<T>` This should address issues with compiling with newer revisions of the C++ language standard.
eyalroz
changed the title
Closed
eyalroz
added a commit
that referenced
this issue
Oct 6, 2022
* Aligned `poor_mans_optional<T>` reset/clear method with the standard library `optional<T>`'s method * A few other tweaks in `poor_mans_optional<T>` * Now using `cuda::optional<T>` in the launch config builder class, rather than forcing the use of `poor_mans_optional<T>` This should address issues with compiling with newer revisions of the C++ language standard.
eyalroz
added a commit
that referenced
this issue
Oct 7, 2022
* Aligned `poor_mans_optional<T>` reset/clear method with the standard library `optional<T>`'s method * A few other tweaks in `poor_mans_optional<T>` * Now using `cuda::optional<T>` in the launch config builder class, rather than forcing the use of `poor_mans_optional<T>` This should address issues with compiling with newer revisions of the C++ language standard.
eyalroz
added a commit
that referenced
this issue
Oct 7, 2022
* Aligned `poor_mans_optional<T>` reset/clear method with the standard library `optional<T>`'s method * A few other tweaks in `poor_mans_optional<T>` * Now using `cuda::optional<T>` in the launch config builder class, rather than forcing the use of `poor_mans_optional<T>` This should address issues with compiling with newer revisions of the C++ language standard.
eyalroz
added a commit
that referenced
this issue
Oct 7, 2022
* Aligned `poor_mans_optional<T>` reset/clear method with the standard library `optional<T>`'s method * A few other tweaks in `poor_mans_optional<T>` * Now using `cuda::optional<T>` in the launch config builder class, rather than forcing the use of `poor_mans_optional<T>` This should address issues with compiling with newer revisions of the C++ language standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, we use an "internal" definition of
optionalin the launch_config_builder class. Instead, we should use the definition intypes.hppwhich falls back to the standard library's in later versions of C++.When we do this, we expose some discrepancies of our own implementation and the standard's, e.g. a different name of the method which clears the optional. The standard uses
reset(), we use other names. So the internally-defined class should be tweaked a little.The text was updated successfully, but these errors were encountered: