Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix up relations of memory.hpp and multi_wrapper_impls/memory.hpp #417

Closed
eyalroz opened this issue Oct 6, 2022 · 0 comments
Closed

fix up relations of memory.hpp and multi_wrapper_impls/memory.hpp #417

eyalroz opened this issue Oct 6, 2022 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 6, 2022 •
edited
Loading

Some functions declared memory.hpp need code from pointer.hpp or elsewhere - so their definitions should be within multi_wrapper_impls, and their declarations should not be inline. Both of these conditions are not always met... cuda::memory::set() needs to be moved, and a couple of declarations need to lose their inline.
@eyalroz eyalroz added the bug label Oct 6, 2022
@eyalroz eyalroz self-assigned this Oct 6, 2022
eyalroz added a commit that referenced this issue Oct 6, 2022
@eyalroz
Fixes #417: memory.hpp vs multi_wrapper_impls/memory.hpp relation…
63f3d40 
… fixes:

* Removed `inline` from declarations with no definitions in `memory.hpp`
* Moved `memory::set()` to `multi_wrapper_impls/memory.hpp`
* Spacing tweaks
eyalroz added a commit that referenced this issue Oct 6, 2022
@eyalroz
Fixes #417: memory.hpp vs multi_wrapper_impls/memory.hpp relation…
2e55de5 
… fixes:

* Removed `inline` from declarations with no definitions in `memory.hpp`
* Moved `memory::set()` to `multi_wrapper_impls/memory.hpp`
* Spacing tweaks
eyalroz added a commit that referenced this issue Oct 7, 2022
@eyalroz
Fixes #417: memory.hpp vs multi_wrapper_impls/memory.hpp relation…
43186ad 
… fixes:

* Removed `inline` from declarations with no definitions in `memory.hpp`
* Moved `memory::set()` to `multi_wrapper_impls/memory.hpp`
* Spacing tweaks
eyalroz added a commit that referenced this issue Oct 7, 2022
@eyalroz
Fixes #417: memory.hpp vs multi_wrapper_impls/memory.hpp relation…
8cb81c5 
… fixes:

* Removed `inline` from declarations with no definitions in `memory.hpp`
* Moved `memory::set()` to `multi_wrapper_impls/memory.hpp`
* Spacing tweaks
eyalroz added a commit that referenced this issue Oct 7, 2022
@eyalroz
Fixes #417: memory.hpp vs multi_wrapper_impls/memory.hpp relation…
89b77ea 
… fixes:

* Removed `inline` from declarations with no definitions in `memory.hpp`
* Moved `memory::set()` to `multi_wrapper_impls/memory.hpp`
* Spacing tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz