Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuda::profiling::mark::range_start and range_end call create_attributions the wrong way #448

Closed
eyalroz opened this issue Dec 28, 2022 · 0 comments
Closed

cuda::profiling::mark::range_start and range_end call create_attributions the wrong way #448

eyalroz opened this issue Dec 28, 2022 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Dec 28, 2022 •
edited
Loading

The functions cuda::profiling::mark::range_start() and cuda::profiling::mark::range_end() call create_attributions(description, color), while:

  1. The function is within the detail_ sub-namespace.
  2. The function takes a color first and a description later
@eyalroz eyalroz added the bug label Dec 28, 2022
@eyalroz eyalroz self-assigned this Dec 28, 2022
eyalroz pushed a commit that referenced this issue Dec 28, 2022
Fixes #448: create_attributes calls in profiling code
6c63741 
* Changed `cuda::profiling::detail_::create_arguments()` to take the description first, then the color
* Now specifying `detail_::` before the calls to `create_arguments()`
* Added invocations of `cuda::profiling::mark::range_start()` and `cuda::profiling::mark::range_end()` to the `vectorAdd_profiled` example program
eyalroz pushed a commit that referenced this issue Feb 10, 2023
@eyalroz
Fixes #448: create_attributes calls in profiling code
ae669a1 
* Changed `cuda::profiling::detail_::create_arguments()` to take the description first, then the color
* Now specifying `detail_::` before the calls to `create_arguments()`
* Added invocations of `cuda::profiling::mark::range_start()` and `cuda::profiling::mark::range_end()` to the `vectorAdd_profiled` example program
eyalroz pushed a commit that referenced this issue Mar 9, 2023
Fixes #448: create_attributes calls in profiling code
eb582e3 
* Changed `cuda::profiling::detail_::create_arguments()` to take the description first, then the color
* Now specifying `detail_::` before the calls to `create_arguments()`
* Added invocations of `cuda::profiling::mark::range_start()` and `cuda::profiling::mark::range_end()` to the `vectorAdd_profiled` example program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz