Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more comparison operators constexpr and noexcept #471

Closed
eyalroz opened this issue Feb 19, 2023 · 0 comments
Closed

Make more comparison operators constexpr and noexcept #471

eyalroz opened this issue Feb 19, 2023 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 19, 2023 •
edited
Loading

Let's make comparison operators noexcept when possible, and constexpr where possible/relevant.
@eyalroz eyalroz added the task label Feb 19, 2023
@eyalroz eyalroz self-assigned this Feb 19, 2023
@eyalroz eyalroz changed the title Make more comparison operators noexcept Make more comparison operators inline and noexcept Feb 19, 2023
@eyalroz eyalroz changed the title Make more comparison operators inline and noexcept Make more comparison operators constexpr and noexcept Feb 19, 2023
eyalroz added a commit that referenced this issue Feb 19, 2023
@eyalroz
Regards #471: Made more operators noexcept and/or constexpr
a174d37 
* Made the status comparison operators `noexcept`
* ... wanted to make the version comparison operators `constexpr`, but can't before C++14, so added a comment
* Spacing tweaks
eyalroz added a commit that referenced this issue Mar 9, 2023
@eyalroz
Regards #471: Made more operators noexcept and/or constexpr
2fbfb85 
* Made the status comparison operators `noexcept`
* ... wanted to make the version comparison operators `constexpr`, but can't before C++14, so added a comment
* Spacing tweaks
eyalroz added a commit that referenced this issue Mar 13, 2023
@eyalroz
Regards #471: Made more operators noexcept and/or constexpr
a0869ba 
* Made the status comparison operators `noexcept`
* ... wanted to make the version comparison operators `constexpr`, but can't before C++14, so added a comment
* Spacing tweaks
@eyalroz eyalroz closed this as completed May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz