Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device::get() marked noexcept #475

Closed
eyalroz opened this issue Feb 26, 2023 · 1 comment
Closed

device::get() marked noexcept #475

eyalroz opened this issue Feb 26, 2023 · 1 comment
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 26, 2023

ensure_driver_is_initialized() and device::get() aren't marked noexcept(false) - and the latter is even marked noexcept. That needs to be fixed.
@eyalroz eyalroz added the bug label Feb 26, 2023
@eyalroz eyalroz self-assigned this Feb 26, 2023
@eyalroz eyalroz changed the title ensure_driver_is_initialized() and device::get() need to be marked noexcept(false) device::get() marked noexcept Feb 26, 2023
@eyalroz
Copy link
Owner Author

eyalroz commented Feb 26, 2023 •
edited

We don't bother with noexcept(false), since it's the default.

@eyalroz eyalroz closed this as completed Feb 26, 2023
@eyalroz eyalroz reopened this Feb 28, 2023
eyalroz pushed a commit that referenced this issue Feb 28, 2023
Fixes #475: Dropped invalid noexcept qualifier from device::get()
accc5f3
eyalroz pushed a commit that referenced this issue Mar 9, 2023
Fixes #475: Dropped invalid noexcept qualifier from device::get()
9380b79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz