Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of negative device id's #487

Closed
eyalroz opened this issue Apr 3, 2023 · 0 comments
Closed

Better handling of negative device id's #487

eyalroz opened this issue Apr 3, 2023 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 3, 2023 •
edited

We should pay more attention to possible cases of users passing negative device IDs by mistake - and complain about this (at least in debug mode).
@eyalroz eyalroz added the task label Apr 3, 2023
@eyalroz eyalroz self-assigned this Apr 3, 2023
eyalroz added a commit that referenced this issue Apr 4, 2023
@eyalroz
Fixes #487: More careful handling of negative device IDs:
57761c2 
* In debug mode, throwing from the `device_t` ctor when the device ID is negative
* When getting a device's name, now printing the ID we tried to get the name for in case of failure (both debug and non-debug builds)
eyalroz added a commit that referenced this issue Apr 5, 2023
@eyalroz
Fixes #487: More careful handling of negative device IDs:
b656008 
* In debug mode, throwing from the `device_t` ctor when the device ID is negative
* When getting a device's name, now printing the ID we tried to get the name for in case of failure (both debug and non-debug builds)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz