Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop inclusion of cooperative_groups.h #492

Closed
eyalroz opened this issue Apr 16, 2023 · 0 comments
Closed

Drop inclusion of cooperative_groups.h #492

eyalroz opened this issue Apr 16, 2023 · 0 comments
Assignees
@eyalroz
Labels
ms-windows Related to the Microsoft Windows operating system resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 16, 2023

For some reason, we include NVIDIA's cooperative_groups.h in launch_configuration.hpp... and we actually don't use it and don't need it. And it drags in a bunch of stuff we don't need - e.g. code from NVIDIA's faux standard library.

Let's drop that. Maybe it'll even help our Windows example program builds.
@eyalroz eyalroz added task ms-windows Related to the Microsoft Windows operating system labels Apr 16, 2023
@eyalroz eyalroz self-assigned this Apr 16, 2023
eyalroz added a commit that referenced this issue Apr 16, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
56994d1 
…t need)
eyalroz added a commit that referenced this issue Apr 16, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
9f4c4fc 
…t need)
eyalroz added a commit that referenced this issue Apr 16, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
305b293 
…t need)
eyalroz added a commit that referenced this issue Apr 17, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
3fa0375 
…t need)
eyalroz added a commit that referenced this issue Apr 17, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
4eea969 
…t need)
eyalroz added a commit that referenced this issue Apr 17, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
5a25d21 
…t need)
eyalroz added a commit that referenced this issue Apr 19, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
8d01f11 
…t need)
eyalroz added a commit that referenced this issue Apr 19, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
e5c9b4e 
…t need)
eyalroz added a commit that referenced this issue Apr 20, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
e038484 
…t need)
eyalroz added a commit that referenced this issue Apr 20, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
1bb824e 
…t need)
eyalroz added a commit that referenced this issue Apr 20, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
afcb73b 
…t need)
eyalroz added a commit that referenced this issue Apr 23, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
a229eba 
…t need)
eyalroz added a commit that referenced this issue Apr 29, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
7d8cc17 
…t need)
eyalroz added a commit that referenced this issue May 1, 2023
@eyalroz
Fixes #492: No longer including cooperative_groups.h (which we don'…
25c3f91 
…t need)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
ms-windows Related to the Microsoft Windows operating system resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz