Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatbin targets placed in "wrong" target folder #495

Closed
eyalroz opened this issue Apr 17, 2023 · 0 comments
Closed

fatbin targets placed in "wrong" target folder #495

eyalroz opened this issue Apr 17, 2023 · 0 comments
Assignees
@eyalroz
Labels
bug build resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 17, 2023

We currently try to place fatbin files procuded via a custom command into CMAKE_RUNTIME_OUTPUT_DIRECTORY; but - that's not where they should go; it should really be CMAKE_CURRENT_BINARY_DIR. This breaks builds on Windows, but strangely not on Linux (which is why I haven't noticed this bug so far).
@eyalroz eyalroz self-assigned this Apr 17, 2023
eyalroz added a commit that referenced this issue Apr 17, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
4fd4aef 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 17, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
acd9a69 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 17, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
46b3fe4 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 17, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
dbdfa44 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 17, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
8ec1dc5 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 19, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
fcee913 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 19, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
2a68334 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 20, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
af031b8 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 20, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
cea6150 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 20, 2023
@eyalroz
Fixes #495: Now using the correct output root dir for custom-command …
82f5cc0 
…fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 23, 2023
@eyalroz
Regards #505, Fixes #495: Now using the correct output root dir for c…
b6489f7 
…ustom-command fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 23, 2023
@eyalroz
Regards #505, Fixes #495: Now using the correct output root dir for c…
cd9a3ee 
…ustom-command fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue Apr 29, 2023
@eyalroz
Regards #505, Fixes #495: Now using the correct output root dir for c…
1482211 
…ustom-command fatbin generation (under `CMAKE_CURRENT_BINARY_DIR`)

test
eyalroz added a commit that referenced this issue Apr 29, 2023
@eyalroz
Regards #505, Fixes #495: Now using the correct output root dir for c…
381a2d3 
…ustom-command fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue May 1, 2023
@eyalroz
Regards #505, Fixes #495: Now using the correct output dir specificat…
b700e4c 
…ion for custom-command fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
eyalroz added a commit that referenced this issue May 1, 2023
@eyalroz
Regards #505, Fixes #495: Now using the correct output dir specificat…
1a39a8a 
…ion for custom-command fatbin generation (`CMAKE_CURRENT_BINARY_DIR`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug build resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz