Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support num_blocks() as an alias for grid_size() in the launch config builder #498

Closed
eyalroz opened this issue Apr 19, 2023 · 0 comments
Closed

Support num_blocks() as an alias for grid_size() in the launch config builder #498

eyalroz opened this issue Apr 19, 2023 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 19, 2023

Some people will find it more intuitive / less confusing to write

my_build.num_blocks(123).build()

rather than

my_build.grid_size(123).build()

as the former better clarifies that it's not the overall grid size. So let's add that as an alias.
@eyalroz eyalroz added the task label Apr 19, 2023
@eyalroz eyalroz self-assigned this Apr 19, 2023
eyalroz added a commit that referenced this issue Apr 19, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
c60f206 
…unch config builder methods
eyalroz added a commit that referenced this issue Apr 20, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
fed6e83 
…unch config builder methods
eyalroz added a commit that referenced this issue Apr 20, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
ee257a5 
…unch config builder methods
eyalroz added a commit that referenced this issue Apr 20, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
a7365a4 
…unch config builder methods
eyalroz added a commit that referenced this issue Apr 22, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
b875e2e 
…unch config builder methods
eyalroz added a commit that referenced this issue Apr 22, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
4853ea8 
…unch config builder methods
eyalroz added a commit that referenced this issue Apr 22, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
a816dc6 
…unch config builder methods
eyalroz added a commit that referenced this issue Apr 23, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
c4c1e88 
…unch config builder methods
eyalroz added a commit that referenced this issue Apr 29, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
efba4e1 
…unch config builder methods
eyalroz added a commit that referenced this issue May 1, 2023
@eyalroz
Fixes #498: Support num_blocks() as an alias of grid_size() as la…
cdf256a 
…unch config builder methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz