Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some example program unique_ptr's need to be float[], not float #534

Closed
eyalroz opened this issue Jul 8, 2023 · 0 comments
Closed

some example program unique_ptr's need to be float[], not float #534

eyalroz opened this issue Jul 8, 2023 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jul 8, 2023

In the vectorAdd.cu example program, we have 3 lines looking like:

auto h_A = std::unique_ptr<float>(new float[numElements]);

... but it should actually be a unique_ptr<float[]>, an array unique_ptr. We also have this in streamOrderedAllocation.cu. Other example programs (including vectorAdd variants) already have this fixed.

@eyalroz eyalroz added the bug label Jul 8, 2023
@eyalroz eyalroz self-assigned this Jul 8, 2023
@eyalroz eyalroz changed the title vectorAdd.cu example unique_ptr's need to be float[], not float some example program unique_ptr's need to be float[], not float Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant