Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robustify namespace use in our macros #542

Closed
eyalroz opened this issue Oct 3, 2023 · 0 comments
Closed

Robustify namespace use in our macros #542

eyalroz opened this issue Oct 3, 2023 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 3, 2023 •
edited
Loading

Some of our macros have potentially-ambiguous identifiers due to lax use of namespaces. Specifically:

  • CAW_SET_SCOPE_CONTEXT has an unqualified cuda::context::whatever use.
  • throw_if_error_lazy assumes it's only used within the ::cuda namespace, and assumes its constructs don't need prefixing

Thanks goes to @aryan-programmer for noticing this issue.
@eyalroz eyalroz added the bug label Oct 3, 2023
@eyalroz eyalroz self-assigned this Oct 3, 2023
eyalroz added a commit that referenced this issue Oct 3, 2023
@eyalroz
Fixes #542: Now using ::cuda:: or sub-namespaces as appropriate in …
f334f6d 
…macros

Fix mostly due to Aryan Chudasama <aryan.programer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz