Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant inclusions of NVIDIA headers #573

Closed
eyalroz opened this issue Jan 22, 2024 · 0 comments
Closed

Remove redundant inclusions of NVIDIA headers #573

eyalroz opened this issue Jan 22, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jan 22, 2024 •
edited
Loading

We include <cuda.h>, <cuda_runtime.h> and <cuda_runtime_api.h> too many times - when we have already necessarily included them earlier. Let's reduce these redundancies.
@eyalroz eyalroz added the task label Jan 22, 2024
@eyalroz eyalroz self-assigned this Jan 22, 2024
eyalroz added a commit that referenced this issue Jan 22, 2024
@eyalroz
Regards #573: Removed redundant inclusions of <cuda.h>.
d0c3518
eyalroz added a commit that referenced this issue Jan 22, 2024
@eyalroz
Regards #573: Removed unnecessary inclusions of <cuda_runtime.h>
e3864f5
eyalroz added a commit that referenced this issue Jan 22, 2024
@eyalroz
Regards #573: Removed redundant inclusions of <cuda.h>.
6d7b570
eyalroz added a commit that referenced this issue Jan 22, 2024
@eyalroz
Regards #573: Removed unnecessary inclusions of <cuda_runtime.h>
bb060f0
eyalroz added a commit that referenced this issue Jan 22, 2024
@eyalroz
Fixes #573: Dropped redundant inclusions of <cuda_runtime_api.h> or…
cd5cc3c 
… moved them to where they're actually needed
eyalroz added a commit that referenced this issue Jan 22, 2024
@eyalroz
Regards #573: Removed redundant inclusions of <cuda.h>.
a209076
eyalroz added a commit that referenced this issue Jan 22, 2024
@eyalroz
Regards #573: Removed unnecessary inclusions of <cuda_runtime.h>
64f3425
eyalroz added a commit that referenced this issue Jan 22, 2024
@eyalroz
Fixes #573: Dropped redundant inclusions of <cuda_runtime_api.h> or…
1b8c029 
… moved them to where they're actually needed
eyalroz added a commit that referenced this issue Jan 27, 2024
@eyalroz
Regards #573: Removed redundant inclusions of <cuda.h>.
a321d87
eyalroz added a commit that referenced this issue Jan 27, 2024
@eyalroz
Regards #573: Removed unnecessary inclusions of <cuda_runtime.h>
f87530d
eyalroz added a commit that referenced this issue Jan 27, 2024
@eyalroz
Fixes #573: Dropped redundant inclusions of <cuda_runtime_api.h> or…
0d0731c 
… moved them to where they're actually needed
eyalroz added a commit that referenced this issue Mar 1, 2024
@eyalroz
Regards #573: Removed redundant inclusions of <cuda.h>.
db4d3e8
eyalroz added a commit that referenced this issue Mar 1, 2024
@eyalroz
Regards #573: Removed unnecessary inclusions of <cuda_runtime.h>
bd6c0ba
@eyalroz eyalroz closed this as completed in a7f67de Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz